Open KW-M opened 1 year ago
Base: 58.21% // Head: 58.41% // Increases project coverage by +0.19%
:tada:
Coverage data is based on head (
44a76f5
) compared to base (f8f8511
). Patch coverage: 64.58% of modified lines in pull request are covered.:exclamation: Current head 44a76f5 differs from pull request most recent head 5478710. Consider uploading reports for the commit 5478710 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi, thank you for your PR, it looks awesome !
While automatic bitrate adjustment is a great feature, it should probably be configurable. We should be able to at least disable it by default and chose the percentage of the detected maximum bandwidth.
Perhaps you could split this PR, letting us merge your bitrate controllers and discuss about how to implement the automatic bitrate adjustment in a dedicated PR ?
Thanks for the suggestions @EmrysMyrddin. I rolled back this PR to just include the bit-rate encoder controllers.
I'm thinking the place to implement the option for auto bit-rate control is in the RTPCodec struct at the beginning of codec.go, and then maybe allow setting the percentage bandwidth used per stream by passing the percentage as a mediaStreamConstraint in getUserMedia(). Does that seem good, or might there be a better way to do it?
Description