pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
535 stars 122 forks source link

Add props even if framerate is not supported by the driver #517

Closed seanavery closed 1 year ago

seanavery commented 1 year ago

Description

This PR fixes an issue where properties are skipped if framerate querying is not supported by the driver. To fix this we simply add width, height, and format if GetSupportedFramerates errors or returns an empty list.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.32 :warning:

Comparison is base (72c1d7b) 59.02% compared to head (d55c96f) 58.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #517 +/- ## ========================================== - Coverage 59.02% 58.70% -0.32% ========================================== Files 63 63 Lines 3854 3875 +21 ========================================== Hits 2275 2275 - Misses 1446 1467 +21 Partials 133 133 ``` | [Impacted Files](https://app.codecov.io/gh/pion/mediadevices/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [pkg/driver/camera/camera\_linux.go](https://app.codecov.io/gh/pion/mediadevices/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-cGtnL2RyaXZlci9jYW1lcmEvY2FtZXJhX2xpbnV4Lmdv) | `24.47% <0.00%> (-1.94%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.