search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
520 stars 119 forks source link

go mod tidy #533

Closed bazile-clyde closed 8 months ago

bazile-clyde commented 8 months ago

Description

The master branch is broken, but it seems simple to fix. go mod tidy should do the trick.

Reference issue

https://github.com/pion/mediadevices/actions/runs/6471054300/job/17568631995#step:5:11

codecov[bot] commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!.

bazile-clyde commented 8 months ago

@at-wat do you think it'd be worthwhile to require passing tests for PRs as a precaution? I don't have strong opinions either way, so just a thought.

at-wat commented 8 months ago

@bazile-clyde the branch protection setting already requires passing tests, and the PR of the broken master commit passed the all tests: https://github.com/pion/mediadevices/actions/runs/6388497827

at-wat commented 8 months ago

We can add a workflow that makes a PR to apply go mod tidy automatically

bazile-clyde commented 8 months ago

@bazile-clyde the branch protection setting already requires passing tests, and the PR of the broken master commit passed the all tests: https://github.com/pion/mediadevices/actions/runs/6388497827

Ah, I see! Very strange. Nevermind then.