search

pion / mediadevices

Go implementation of the MediaDevices API.
https://pion.ly/
MIT License
535 stars 121 forks source link

update: remove cpp inline function #560

Closed qiulin closed 5 months ago

qiulin commented 6 months ago

Description

Reference issue

Parttial fixes #347, remove inline function in cpp, which will cause compiling problem when deubug

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.63%. Comparing base (38a3b82) to head (4e3ff6d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #560 +/- ## ======================================= Coverage 58.63% 58.63% ======================================= Files 63 63 Lines 3885 3885 ======================================= Hits 2278 2278 Misses 1473 1473 Partials 134 134 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

edaniels commented 6 months ago

@qiulin could you run go mod tidy to resolve the go.sum changing?

qiulin commented 5 months ago

@qiulin could you run go mod tidy to resolve the go.sum changing?

ok, i will close this PR, and open a new one