pion / rtp

A Go implementation of RTP
https://pion.ly/
MIT License
363 stars 112 forks source link

H264 spreader #194

Open jvary opened 2 years ago

jvary commented 2 years ago

REQUEST FOR COMMENTS: H264 spreader : reduces the RTP payload size so 3rd parties RTP sources can be properly redirected over SRTP/WebRTC without IP fragmentation.

High level steps:

The steps above handle :

Advantages vs building whole H264 Frame as you initially proposed:

Future improvement: back-buffer to persist between Process(), to avoid making new buffer for each new returned RTP.

jvary@genetec.com

jvary commented 1 year ago

Ok, it looks like there is little interest for this PR/feature, so closing it.

Sean-Der commented 1 year ago

Hi @jvary i would like to take this! I am just very overwhelmed with PRs

Sean-Der commented 1 year ago

I will review and address all issues myself :)

jvary commented 1 year ago

Oh! Glad there is interest! We continued development in-house (and fixed 1-2 bugs as well), so I will update this PR. @Sean-Der : question : would you rather have the 'interface' dealing with raw slices (as right-now), or have rtp.Packet in input/output ?