pion / rtp

A Go implementation of RTP
https://pion.ly/
MIT License
356 stars 111 forks source link

Add VLA support - an RTP header extension parser/builder #245

Closed enobufs closed 9 months ago

enobufs commented 10 months ago

Introducing an unmarshaler/marshaler for VLA (Video Layers Allocation), an RTP header extension. This extension is for a video sender to provide information about the target bitrate, resolution and frame rate of each scalability layer in order to aid a selective forwarding middlebox to decide which layer to relay.

NOTE: This change only adds the VLA parser/builder to this module (expected minor change), will not introduce any behavioral change to the existing code.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (314bd8e) 87.50% compared to head (eef54d7) 87.41%.

Files Patch % Lines
vlaextension.go 86.46% 25 Missing and 6 partials :warning:
codecs/av1/obu/leb128.go 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #245 +/- ## ========================================== - Coverage 87.50% 87.41% -0.10% ========================================== Files 20 21 +1 Lines 1873 2113 +240 ========================================== + Hits 1639 1847 +208 - Misses 204 230 +26 - Partials 30 36 +6 ``` | [Flag](https://app.codecov.io/gh/pion/rtp/pull/245/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/rtp/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `87.41% <86.66%> (-0.10%)` | :arrow_down: | | [wasm](https://app.codecov.io/gh/pion/rtp/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `86.89% <86.66%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.