pion / rtp

A Go implementation of RTP
https://pion.ly/
MIT License
349 stars 111 forks source link

Fix rare SRTP loss decode failure #277

Closed kcaffrey closed 1 month ago

kcaffrey commented 1 month ago

As described in https://webrtc-review.googlesource.com/c/src/+/358360 there can be a problem when the sequence number starts near the rollover point and there is packet loss. As linked to in that issue, libsrtp recommends having the starting sequence number be less than 2^15 to avoid that problem.

Sean-Der commented 1 month ago

Thank you @kcaffrey merge + tag where ever you need it :)

boks1971 commented 1 month ago

Good catch!

nils-ohlmeier commented 1 month ago

@kcaffrey you beat me to it :-) I think this is worth releasing a new version, because without this fix you will get random call failures.