codecov[bot]
commented
5 months ago Codecov Report
Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 67.38%. Comparing base (
f0386f2) to head (39fd7dd).
| Files | Patch % | Lines |
|---|---|---|
| association.go | 50.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #327 +/- ## =========================================== - Coverage 81.13% 67.38% -13.76% =========================================== Files 49 49 Lines 4188 4194 +6 =========================================== - Hits 3398 2826 -572 - Misses 647 1207 +560 - Partials 143 161 +18 ``` | [Flag](https://app.codecov.io/gh/pion/sctp/pull/327/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/sctp/pull/327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `?` | | | [wasm](https://app.codecov.io/gh/pion/sctp/pull/327/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `67.38% <50.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The SCTP implementation used in v3.2.28 fails to establish a connection with other WebRTC implementations. The implementation of ZeroChecksum assumes incorrectly that the feature is bi-directional
SCTP ZeroChecksum is actually a uni-directional feature which causes the Assocations to be unable to communicate.