Closed paulwe closed 7 months ago
Attention: Patch coverage is 74.13442%
with 254 lines
in your changes are missing coverage. Please review.
Project coverage is 65.84%. Comparing base (
fb77fb3
) to head (d8d785d
).
Files | Patch % | Lines |
---|---|---|
unmarshal.go | 66.37% | 118 Missing and 38 partials :warning: |
util.go | 34.84% | 40 Missing and 3 partials :warning: |
marshal.go | 84.29% | 30 Missing :warning: |
jsep.go | 10.00% | 9 Missing :warning: |
media_description.go | 84.61% | 4 Missing and 2 partials :warning: |
extmap.go | 91.89% | 3 Missing :warning: |
session_description.go | 95.71% | 3 Missing :warning: |
common_description.go | 97.50% | 2 Missing :warning: |
time_description.go | 92.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@paulwe I bumped the go.mod
to start a /v4
release for the breaking changes
@paulwe It would be nice to break this commit up into what has changed.
Others will come and read when a breaking change happened (so they can fix their code). It would be nice if we could give them a log that is useful!
i can expand on what has changed in the commit message but i'm definitely not going through this and splitting it up on the off chance someone is using this library but can't figure out how to change pointers to value types...
improves marshal/unmarshal performance and reduces the number of heap objects held by
SessionDescription
structs. this should be backward compatible except for all the places where pointers are replaced with value types...