pion / sdp

A Go implementation of the SDP
https://pion.ly/
MIT License
148 stars 56 forks source link

Add UnmarshalString #175

Closed Sean-Der closed 7 months ago

Sean-Der commented 7 months ago

Before ''' 2512 B/op 83 allocs/op '''

After ''' 2016 B/op 47 allocs/op '''

Description

Reference issue

Fixes #...

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.67%. Comparing base (adf8269) to head (0b24c8c).

Files Patch % Lines
unmarshal.go 83.33% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #175 +/- ## ========================================== + Coverage 64.22% 64.67% +0.45% ========================================== Files 11 12 +1 Lines 1526 1571 +45 ========================================== + Hits 980 1016 +36 - Misses 446 454 +8 - Partials 100 101 +1 ``` | [Flag](https://app.codecov.io/gh/pion/sdp/pull/175/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/sdp/pull/175/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.67% <91.37%> (+0.45%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/sdp/pull/175/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.67% <91.37%> (+0.45%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.