pion / srtp

A Go implementation of SRTP
MIT License
119 stars 49 forks source link

Fix rollover estimation after SetROC #227

Closed at-wat closed 1 year ago

at-wat commented 1 year ago

SRTP context estimated the wrong ROC when the sequence number is overflown during burst packet loss, and SetROC gives the correct ROC.

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.56% // Head: 76.58% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (e262500) compared to base (e966eef). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #227 +/- ## ========================================== + Coverage 76.56% 76.58% +0.01% ========================================== Files 17 17 Lines 1233 1234 +1 ========================================== + Hits 944 945 +1 Misses 198 198 Partials 91 91 ``` | Flag | Coverage Δ | | |---|---|---| | go | `76.58% <100.00%> (+0.01%)` | :arrow_up: | | wasm | `76.09% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pion/srtp/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [context.go](https://codecov.io/gh/pion/srtp/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-Y29udGV4dC5nbw==) | `88.61% <100.00%> (+0.09%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.