codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
Project coverage is 78.83%. Comparing base (
180f6ef) to head (2f5b344).
| Files | Patch % | Lines |
|---|---|---|
| protection_profile.go | 83.33% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== + Coverage 78.77% 78.83% +0.05% ========================================== Files 17 17 Lines 980 992 +12 ========================================== + Hits 772 782 +10 - Misses 116 118 +2 Partials 92 92 ``` | [Flag](https://app.codecov.io/gh/pion/srtp/pull/279/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/srtp/pull/279/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.83% <83.33%> (+0.05%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/srtp/pull/279/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.32% <83.33%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Moved tests from srtp_cipher_aead_aes_gcm_test.go to new file, cleaned up their code to make it more DRY. Added tests for AES CM ciphers there too.
This new cipher test suite will make it easier to add tests for new SRTP features without lots of copy/paste.