Merge with gortc/stun - Githubissues

pion / stun

A Go implementation of STUN

https://pion.ly/

MIT License

625 stars 94 forks source link

Merge with gortc/stun #11

Closed ernado closed 5 years ago

ernado commented 5 years ago

Ref: #10

The CI should be updated too.

ernado commented 5 years ago

Please take a look at the following points

[ ] LICENSE (I've used xor implementation and vendored hmac from go source)
[ ] AUTHORS (I've just appended authors from README to that file)

I think we don't need v2 or even v1, because current package version is v0.2. So I propose to release v0.3.0 and then further adapt API if needed.

backkem commented 5 years ago

Regarding vendoring, here's an example we did earlier: https://github.com/pion/webrtc/tree/master/examples/vendor-wasm. It's a little different situation thought.

Anyway, this is looking great. This implementation is far superior to what we had before.

Sean-Der commented 5 years ago

Everything looks great to me!

Would you prefer we move Contributors sections of README files into AUTHORS file? My motivation with that was to get people excited to see their name in the README file, when I was first starting out with Open Source that always excited me.

LICENSE wise I am happy as long as we don't require people to redistribute changes :) same goal as you here I really want to be 'Enterprise' friendly. Those users contribute a lot back (bug reports and driving excitement)

ernado commented 5 years ago

Oops, accidently pushed the wrong button

Sean-Der commented 5 years ago

@ernado I say when you are ready lets merge across stun then ice and webrtc!

When it lands we can fix/confirm things as we go :)