pion / stun

A Go implementation of STUN
https://pion.ly/
MIT License
601 stars 91 forks source link

Use XorBytes from pion/transport #116

Closed jech closed 1 year ago

jech commented 2 years ago

This should not do much for performance, but we might as well use a single, well-maintained copy of XorBytes.

Related to https://github.com/pion/transport/commit/f0728d9ef5c3348561b849721055b109ac5c91d2. CC @adriancable

codecov[bot] commented 2 years ago

Codecov Report

Merging #116 (cc8878c) into master (7e647ef) will decrease coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   98.19%   98.16%   -0.04%     
==========================================
  Files          20       19       -1     
  Lines        1608     1577      -31     
==========================================
- Hits         1579     1548      -31     
  Misses         23       23              
  Partials        6        6              
Flag Coverage Δ
go 98.16% <100.00%> (-0.04%) :arrow_down:
wasm 57.61% <50.00%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xoraddr.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e647ef...cc8878c. Read the comment docs.