Closed SubOptimal closed 1 year ago
Base: 98.19% // Head: 98.19% // No change to project coverage :thumbsup:
Coverage data is based on head (
61be8a2
) compared to base (7e647ef
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey @SubOptimal, can you please fix linter issues? You can also find them in .github folder and run locally.
@SubOptimal thank you for the contribution!
Description
The installation documentation mention
go get
as the command to install the executable, which was deprecated with Go v1.17.0 and will lead to an error.Reference issue
Assuming that PR #118 might be implemented, the command to install executables should be amended to
go install
.PR #118 should be taken into account as the compilation with Go v.1.12.0 will lead to an error.
PS: Please let me know if I missed some step for contribution. But the offered link to CONTRIBUTING.md mention to check https://pion.ly/knowledge-base/pion-internals/. That link end with a HTTP 404 error.