search

pion / stun

A Go implementation of STUN
https://pion.ly/
MIT License
601 stars 91 forks source link

Port old fuzzing code to Go's new fuzzing tools #138

Closed stv0g closed 1 year ago

stv0g commented 1 year ago

Fixes #136

stv0g commented 1 year ago

The new fuzzing tool already found its first bug: https://github.com/pion/stun/actions/runs/3985928865/jobs/6833891029

codecov[bot] commented 1 year ago

Codecov Report

Base: 98.16% // Head: 98.16% // No change to project coverage :thumbsup:

Coverage data is based on head (cca5780) compared to base (92fd614). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head cca5780 differs from pull request most recent head 9df3f4a. Consider uploading reports for the commit 9df3f4a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #138 +/- ## ======================================= Coverage 98.16% 98.16% ======================================= Files 19 19 Lines 1577 1577 ======================================= Hits 1548 1548 Misses 23 23 Partials 6 6 ``` | Flag | Coverage Δ | | |---|---|---| | go | `98.16% <100.00%> (ø)` | | | wasm | `61.56% <100.00%> (+3.95%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pion/stun/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [errorcode.go](https://codecov.io/gh/pion/stun/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#diff-ZXJyb3Jjb2RlLmdv) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stv0g commented 1 year ago

I also squashed the changes and added you as Co-author

stv0g commented 1 year ago

Thanks for the thorough review :)