enobufs commented 5 years ago

Fixes #21 See #21 for details

Tested with old STUN server, and now we can decode the response with the attribute with old value correctly.

enobufs commented 5 years ago

@Sean-Der could you help me fixing the build error? I guess it is related to golangci-lint version but the error looks different from what I saw earlier. (not sure what is going on). Build and lint check succeeded locally...

enobufs commented 5 years ago

The same error as this one: https://github.com/pion/turn/pull/85#issuecomment-521868643 pion/stun has ParseURI method which has the exact same problem. This uri.go is not used in pion. I am going to remove it.

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will decrease coverage by 0.16%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage     100%   99.83%   -0.17%     
==========================================
  Files          19       18       -1     
  Lines        1209     1190      -19     
==========================================
- Hits         1209     1188      -21     
- Misses          0        1       +1     
- Partials        0        1       +1

Impacted Files	Coverage Δ
message.go	`100% <100%> (ø)`	:arrow_up:
helpers.go	`100% <100%> (ø)`	:arrow_up:
attributes.go	`95.65% <50%> (-4.35%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e96418...7df0d37. Read the comment docs.

Sean-Der commented 5 years ago

Oh nice, thank you @enobufs!

I updated to latest golangci-lint will merge this when everything passes. Thank you so much for fixing :)

pion / stun

Translate old XOR-MAPPED-ADDRESS type value to new one #22

Codecov Report