search

pion / stun

A Go implementation of STUN
https://pion.ly/
MIT License
616 stars 94 forks source link

Constrain stun-client to use IPv4 #72

Closed jech closed 3 years ago

jech commented 3 years ago

The function stun.Dial only tries the first address; for a double-stack host (IPv4 and IPv6), this will be an IPv6 address, which will either provide useless information (the global IPv6 address, which is already known), or will hang if the STUN server is IPv4-only.

Fixes #70.

codecov[bot] commented 3 years ago

Codecov Report

Merging #72 (882d3ab) into master (9064cf3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          19       19           
  Lines        1086     1086           
=======================================
  Hits         1068     1068           
  Misses         12       12           
  Partials        6        6
Flag Coverage Δ
go 98.34% <ø> (ø)
wasm 55.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9064cf3...882d3ab. Read the comment docs.