search

pion / stun

A Go implementation of STUN
https://pion.ly/
MIT License
616 stars 94 forks source link

Allow unaligned access on ARM64 #73

Closed jech closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #73 (e0886c9) into master (9064cf3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          19       19           
  Lines        1086     1086           
=======================================
  Hits         1068     1068           
  Misses         12       12           
  Partials        6        6
Flag Coverage Δ
go 98.34% <ø> (ø)
wasm 55.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xor.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9064cf3...e0886c9. Read the comment docs.

Sean-Der commented 3 years ago

@jech is it possible to have ARM64 devices that don't support it? We can cross that bridge when we get the bug report :)

jech commented 3 years ago

Unaligned access is mandatory on ARMv6 or later. 64-bit implies ARMv8, so we're fine, barring buggy hardware.

(I was tempted to add ARM to the conditional, since ARMv5 is pretty much obsolete, but ARMv5 would silently yield wrong results rather than crashing, so I didn't want to take the risk.)