Closed jinleileiking closed 3 years ago
Merging #79 (5a8daec) into master (c15a9ed) will decrease coverage by
42.83%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #79 +/- ##
===========================================
- Coverage 98.16% 55.33% -42.84%
===========================================
Files 20 19 -1
Lines 1091 1088 -3
===========================================
- Hits 1071 602 -469
- Misses 14 452 +438
- Partials 6 34 +28
Flag | Coverage Δ | |
---|---|---|
go | ? |
|
wasm | 55.33% <0.00%> (-0.11%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
message.go | 55.60% <0.00%> (-44.40%) |
:arrow_down: |
client.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
errorcode.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
xor.go | 35.00% <0.00%> (-65.00%) |
:arrow_down: |
xoraddr.go | 35.18% <0.00%> (-64.82%) |
:arrow_down: |
checks.go | 64.28% <0.00%> (-35.72%) |
:arrow_down: |
fingerprint.go | 78.94% <0.00%> (-21.06%) |
:arrow_down: |
errors.go | 80.00% <0.00%> (-20.00%) |
:arrow_down: |
textattrs.go | 84.00% <0.00%> (-16.00%) |
:arrow_down: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c15a9ed...5a8daec. Read the comment docs.
Hey @jinleileiking
This change LGTM! Would you mind fixing the test fails, then happy to merge :)
@Sean-Der --- FAIL: ExampleMessage (0.00s) seems go test needs a fix
@Sean-Der I comment this ExampleMessage test func for passing test
@Sean-Der ready for merge :)
Merged with 0f7f72b905d54eaf8e477af78c6a3d42f54ea217
Thanks @jinleileiking I just fixed the test
Description
Reference issue
Fixes #...