pion / turn

Pion TURN, an API for building TURN clients and servers
MIT License
1.87k stars 319 forks source link

Remove pessimistic String calls for low level logs #389

Closed paulwe closed 7 months ago

paulwe commented 7 months ago

there is no need to manually stringify types that implement fmt.Stringer. if the log line is printed the formatter for %s will do this.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (cf40c33) to head (5528f7b).

:exclamation: Current head 5528f7b differs from pull request most recent head 71ef030. Consider uploading reports for the commit 71ef030 to get more accurate results

Files Patch % Lines
client.go 40.00% 3 Missing :warning:
internal/allocation/allocation.go 80.00% 1 Missing :warning:
internal/server/turn.go 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #389 +/- ## ========================================== + Coverage 68.24% 68.40% +0.15% ========================================== Files 43 43 Lines 2337 2333 -4 ========================================== + Hits 1595 1596 +1 + Misses 576 573 -3 + Partials 166 164 -2 ``` | [Flag](https://app.codecov.io/gh/pion/turn/pull/389/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/turn/pull/389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `68.40% <79.16%> (+0.15%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/turn/pull/389/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `27.64% <0.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.