Open Sean-Der opened 1 year ago
Not needed but may be good to address https://github.com/pion/webrtc/issues/2292
Maybe we can revert this revert as networkType is not "tcp4"/"tcp6"/etc according to the webrtc-stats?
Also, I find very confusing that we have
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGathererState))
not
func (pc *PeerConnection) OnICEGatheringStateChange(f func(ICEGatheringState))
even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState
I suggest it is worth making more consistent
even though getter is more accurate:
func (pc *PeerConnection) ICEGatheringState() ICEGatheringState
@aalekseevx Do you mean to do polling instead of event callback?
@at-wat, no, I think this change would be too radical :) I'm just suggesting changing the return type of OnICEGatheringStateChange
from ICEGathererState
to ICEGatheringState
(both types already present in implementation). Mapping could be done this way
@aalekseevx nice catch! I will make both changes
Better to remove deprecated things
Created v4 milestone to track the issues/PRs targeting v4
@at-wat @edaniels (and anyone who is active in this thread)
What do you think of dropping pion/logging for the stdlib's slog? I don't want to put too much annoyance on users, but the less custom things we have the better!
Using slog sounds good, but slog config should be configurable via webrtc.SettingEngine
or something similar.
Currently, I use https://github.com/pion/zapion in my products. https://github.com/samber/slog-zap seems be usable if pion/logging is replaced by slog.
I'm onboard with that. Also love using zap
Found a performance regression in SampleBuilder: https://github.com/pion/webrtc/issues/2778
I merged a breaking change with 60eea430ac0c09bbeb0e7a96fadeffad4dab87aa
This added support for DTLS Close Notify. This means the PeerConnection will transition to
Closed
directly without user interaction. Pion's documentation only suggested handlingFailed
andDisconnected
before. Users will need to manually audit their code before upgrading.Since we are breaking the API does anyone else things that are worth changing?
Changes
Complete
TODO
Review/Clear Issue Backlog for dependencies
pion/interceptor
pion/rtcp
pion/rtp
pion/sctp
pion/srtp
pion/turn