pion / webrtc

Pure Go implementation of the WebRTC API
https://pion.ly
MIT License
13.88k stars 1.66k forks source link

Support more data from webrtc stats #2916

Closed aalekseevx closed 1 month ago

aalekseevx commented 1 month ago

Description

Parse more webrtc stats according to https://www.w3.org/TR/webrtc-stats/

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (5637661) to head (dccfbb2). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
icetransportstate.go 53.33% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2916 +/- ## ========================================== + Coverage 78.99% 79.12% +0.12% ========================================== Files 89 89 Lines 8541 8564 +23 ========================================== + Hits 6747 6776 +29 + Misses 1303 1302 -1 + Partials 491 486 -5 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2916/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2916/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `80.68% <53.33%> (+0.13%)` | :arrow_up: | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2916/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.47% <23.33%> (-0.46%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sean-Der commented 1 month ago

LGTM! Mind fixing the lints and good to merge :)

aalekseevx commented 1 month ago

@Sean-Der, I think he's happy now 👍