pion / webrtc

Pure Go implementation of the WebRTC API
https://pion.ly
MIT License
13.88k stars 1.66k forks source link

Fix ssrc-group ordering #2925

Closed Sean-Der closed 1 month ago

Sean-Der commented 1 month ago

SSRCes were flipped incorrectly

Fixes #2922

Sean-Der commented 1 month ago

Opening another PR. This is not the right fix -_-

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.65%. Comparing base (d6141bd) to head (27c646d). Report is 1 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (d6141bd) and HEAD (27c646d). Click for more details.

HEAD has 2 uploads less than BASE | Flag | BASE (d6141bd) | HEAD (27c646d) | |------|------|------| |go|2|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2925 +/- ## =========================================== - Coverage 78.93% 64.65% -14.29% =========================================== Files 89 67 -22 Lines 8564 3296 -5268 =========================================== - Hits 6760 2131 -4629 + Misses 1314 1039 -275 + Partials 490 126 -364 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2925/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `?` | | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `64.65% <ø> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.