Raise the default ReceiveMTU to 1500

pion / webrtc

Pure Go implementation of the WebRTC API

https://pion.ly

MIT License

13.88k stars 1.66k forks source link

Raise the default ReceiveMTU to 1500 #2932

Closed braveyao closed 1 month ago

braveyao commented 1 month ago

Description

Raise the default ReceiveMTU to 1500, as same as the default MTU setting of WebRTC. This is because some senders, i.e. FFmpeg, may packetize RTP with 1460 payload + 12 RTP header + etc.

Reference issue

Fixes #2927

Sean-Der commented 1 month ago

LGTM @braveyao! Can you rebase and I will merge

braveyao commented 1 month ago

Hi, it's based on the latest and I ran "pull --rebase" again. It says rebase will update the PR automagically, but I didn't see anything noticeable. What's the status at your side? Anything else I missed?

Sean-Der commented 1 month ago

Merged with 8fbf8219ddbe6b81feb24999fb547eb415e95a54

@braveyao I also added you to pion org. You can push branches directly to repo now, should make things easier!

braveyao commented 1 month ago

Nice! I'm a Pion member now! 👍