codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 25.71429% with 26 lines in your changes missing coverage. Please review.
Project coverage is 77.42%. Comparing base (
271ab55) to head (a0a3d53).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/media/ivfwriter/ivfwriter.go | 25.71% | 26 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2938 +/- ## ========================================== - Coverage 79.01% 77.42% -1.60% ========================================== Files 89 89 Lines 8584 10489 +1905 ========================================== + Hits 6783 8121 +1338 - Misses 1311 1877 +566 - Partials 490 491 +1 ``` | [Flag](https://app.codecov.io/gh/pion/webrtc/pull/2938/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/pion/webrtc/pull/2938/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `78.96% <25.71%> (-1.61%)` | :arrow_down: | | [wasm](https://app.codecov.io/gh/pion/webrtc/pull/2938/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion) | `63.16% <25.71%> (-0.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pion#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Adds the necessary wiring to get VP9 to work with
ivfwriteras well as a save-to-disk example.It currently assumes 30 fps but it seems that the other codecs also assume 30 fps so that is not a net-new assumption.
Reference issue
Fixes #...