Closed Mohammed0987 closed 7 years ago
Also merge both sch and brd
Alright. Some comments here:
It looks like that two of them are where the bottom layer connections are trying to be connected to the top, but there are no vias between the top and the bottom layer.
We need much larger traces / planes for these high power connections. Consult a PCB trace width calculator. You'll need much, much wider traces / use ground planes. It'd be best to get some better / more complex ground planes.
This may be partially caused by the XT60 connector and the JST connector being right right next to each other. They can be moved a bit apart. You'll have the room if the XT60 connector moves a little towards the bottom right.
Keep it up! It's going well.
Updated comments. Two sections of comments: Critical (For board order, must be fixed), and "Would be nice"
Critical: -A drill, U$3, is currently placed at 0.4 x 5.1, off the edge of the board. it either must be moved onto the board or removed. -Need to fix the fact that there are two board files (PDB.brd and PDB_MH.brd, but only one schematic file.) Forward/ Back annotation is broken, which is very not good. The wrong version could accidentally get ordered. -The XT60 connector needs to be re-oriented. In its current position / location, there is very little copper carrying the return current to the battery. (Approx .3 inches) A change of how the 5V line on the bottom of the PCB is routed could probably also accomplish this goal. -JP2 needs to be moved to the edge of the board.
Would be nice: -The frame on second page of schematic needs to be fixed. (updated with correct info) -It's not ideal to have a bolt hole in the middle of the high current power plane. (u$5) -There's a lot of overlapping silkscreen. Could use some work to cleanup, but this can def wait till rev c. The silkscreen could stand to be much cleaner, and have the high-precision resistors explicitly labeled as such. (View the battery buzzer for a good example) -Could be smaller. This could possibly be achieved w/ better routing of the buzzer section -The polygon carrying Bat+ is not square. It's not parallel to the x-axis. Several of the other polygons are also not straight (to lesser degrees). -Silkscreen labels that explain the function of the buttons would be good. -Silkscreen labels on the fuses aren't symmetric.
There is an extra mounting hole above the board that should be deleted.... that's covered by Doug's comment.
The mounting hole U$5 is still in the middle of the BAT power plane. I would try moving it to the left, next to the resistors (you may need to reroute BCELL3 trace).
Also, I'm concerned that the BAT polygon is too narrow near the DPST_SWITCH. I would make it wider by moving up the bottom edge of the 5V plane, so you can make the BAT plane wider below it. Like this:
(NOTE: there is a small 5V trace with a via that may need to be moved up as well)
Is this done? If so we can merge :-))
I believe so.
The current schematic file that is in the repo does no include the battery buzzer components. We need to find the correct version of the schematic and replace it in the repo.
Please double check that the stop masks are not a problem. Run DRC on it. Also double check the silkscreen and electrical style guidelines.