pioneers / shepherd

baa
Apache License 2.0
2 stars 2 forks source link

Windows YDL is bad #60

Closed sberkun closed 1 year ago

sberkun commented 3 years ago

Migrate YDL from onboarding repo

sberkun commented 1 year ago

Historical context: I think this was because at the time this issue was opened, this was "old YDL" that used a queue. For some reason, waiting on the queue prevented SIGINT (ctrl-c) from working properly, so Matt (the only Windows user) had to manually kill shepherd.py every time he wanted to restart it.

I don't remember what the fix was at this point in time (I think it was putting a timeout on queue.get, but that doesn't explain why the description says "migrate YDL from onboarding repo").

Anyway, this is now resolved because YDL was updated like a year ago to not use queues.