search

pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.64k stars 380 forks source link

Program crash when selecting mail run to EV Lacertae #117

Closed SeanN closed 13 years ago

SeanN commented 13 years ago

Alpha 11 dev 6060077 Windows Vista 32 Nvidia 9600 m

At Mexico city when I select a mail run to EV Lacertae the program stops with the following error message:

Assertion Failed program:... file: StarSystem.cpp Line 884 expression: path->sbodyId<m.bodies.size ()

I don't know if this helps but EV lacertae doesn't have any population.

robn commented 13 years ago

Just to make it clear, can you confirm this happens at the moment you select the ad from the bulletin board?

SeanN commented 13 years ago

That's correct. I click on the square and it sends me to the desktop.

robn commented 13 years ago

Good that I know, bad in that I can't reproduce it.

The crash is that its trying to look up the starport that the ad is pointing to, but since it has no starports that naturally fails. The trouble is that it should not have been possible for the script to even select that system - it loops over them and discards the ones with no starports. I've prodded at those methods as hard as I can but I can't get them to fail in this way.

I suppose there is an issue in that it shouldn't be possible to trigger a hard assertion from Lua, but its also very hard to rule them out. For the actual cause we're just going to have to wait until it pops up again and try to collect more data.

SeanN commented 13 years ago

Thanks for the reply. You're right about reproducing the crash. I tried last night to get the same results but couldn't find a run to the same system. I'll keep an eye out for it though.

SeanN commented 13 years ago

On an additional note: Using dev build fabea7a-win32: I just failed a delivery mission to Alpha Centauri and tried to pick up another delivery to Sol. Upon clicking on the square I got the following:

error:data/modules/DeliverPackage.lua.82:attempt to index local 'ad' (a nil value)

robn commented 13 years ago

@SeanN thanks, added new issue #123 as its unrelated, not to mention frustrating - I fixed this already but must have missed a particular case.

Brianetta commented 13 years ago

This issue is a candidate for closure. I'll give it a day or two to let people show an interest.