pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.63k stars 377 forks source link

Inconsistencies in Meteor #1234

Closed walterar closed 12 years ago

walterar commented 12 years ago
max_cargo = 5,
max_laser = 1,
max_missile = 4, ?
max_fuelscoop = 1, ?
max_cargoscoop = 0,
max_ecm = 0, ?
max_engine = 0, ***?
hyperdrive_class = 1,
capacity = 12,
hull_mass = 5,
fuel_tank_mass = 7,
thruster_fuel_use = 0.0005,
price = 18000,
robn commented 12 years ago

max_engine = 0 is a bug, thanks. The rest look fine. What are your concerns exactly?

walterar commented 12 years ago

max_missile = 4, ? max_fuelscoop = 1, ?

On a boat so small?

max_ecm = 0, ?

Why?

robn commented 12 years ago

The missiles are there because this thing is too small to pack shields or decent weaponry. The idea is that if it came under attack, it would throw a pile of missiles at the enemy and then use its powerful main thruster to run away.

Fuel scoop and ECM are largely arbitrary, but use your imagination. Just because it can accept a fuel scoop doesn't mean its a good idea. And no ECM? Who knows. Maybe its size and shape are such that an ECM would be either ineffective or dangerous. Its the joy of invented tech; who can say how it works?

@AaronSenese, your input would be welcome here.

walterar commented 12 years ago

:)

AaronSenese commented 12 years ago

I don't know a lot about the scale of the equipment you can fit on ships so some of these were inferences. Are fuelscoops supposed to be huge? I was sort of thinking back to the transatmospheric air-skimmer plane in Fallen Angels (title?) by Arthur C. Clarke. I suppose a craft like this shouldn't be operating away from base that long anyway.

As for ECM, I suppose it could fit one. It would fit its 'runner' role most effectively. Other then that, Robn's right about the missiles. The craft is only going to have one hardpoint so that's to compensate.

walterar commented 12 years ago

I do not know the reasons for the incorporation of an unfinished model. Clearly that was never proven.

I really like Meteor, but Aaron, you should try playing with his ship in Pioneer.

Luomu commented 12 years ago

I do not know the reasons for the incorporation of an unfinished model. Clearly that was never proven.

Unbalanced ship, not unfinished model. Not a big deal.

Since you are interested in balance and know how to manipulate the stats, here is your chance to contribute. The next time someone contributes a ship, try it and comment before it is merged. For example #1230.

walterar commented 12 years ago

Luomu, my contribution today is this.

Take it or leave it.

walterar commented 12 years ago

I think it is a good choice between 22 and 30 t.

http://www.youtube.com/watch?v=MBs8-ePzmnw

walterar commented 12 years ago

Ok, fine.

I imagine that there aft skids.

I imagine that the skid comes in a bow door

I imagine that the model is finished.

Close.

robn commented 12 years ago

Oh, that's what you're complaining about. Perhaps you should have just said that?

To answer your "question": Pioneer is alpha-quality. Its obviously unfinished, and work-in-progress code and assets goes in all the time. I find it odd that you consider this a problem yet have not mentioned almost every change that happens without being "finished".

walterar commented 12 years ago

I "imagine" that things are tested "before" to merge with master.

I see that it is not.

Brianetta commented 12 years ago

Tested by whom, walterar? The whole point of an alpha test programme is to increase exposure of the code to people whom are interested in testing. Things are tested for basic stability (code must compile, and function broadly as described in the pull request) before they are merged into master, but these things (pull requests) are usually written by a single developer, with feedback and review from one or two others if they have time.

It's not just unreasonable to expect the person who wrote the code to test it, it's bad practice. So, code is merged into master, and is tested by those testers who follow the master branch or who download the nightly builds. If they're good, they go into the alpha build for testing by the wider public.

Don't for a moment assume that the master development branch is finished software, or can be treated as such. If you want to contribute to testing, then please test. Offer us constructive feedback. Describe what's wrong, what's right and any specific ideas you might have for improvement.

What you've given in this issue isn't constructive. It comes across as you being angry and incredulous at the audacity of the dev team to let you play unfinished software, and that's just plain rude.

If you're here to help us, please do so. We don't mind you suggesting changes. We don't mind you making changes yourself. It's encouraged, in fact. We'd love you to take ownership of Pioneer with us. That's how free software takes life.

walterar commented 12 years ago

"What you've given in this issue isn't constructive. It comes across as you being angry and incredulous at the audacity of the dev team to let you play unfinished software, and that's just plain rude."

It was not my intention, sorry.

Maybe I worry too much about the proximity of the release of the beta 22.

I prefer to do the reviews here before the "general public".

Meteor is very promising and hopefully out minimally over.

I could say much more but I fear that Google translator make me understand less.

robn commented 12 years ago

beta 22

Alpha 22. Seems like a subtle thing, but its a whole world of difference.

walterar commented 12 years ago

Pioneer currently has three modules of game: taxi, delivery and assassination.

For none of them is useful in 12t Meteor. Yes in 22t. Try it.

walterar commented 12 years ago

"Alpha 22. Seems like a subtle thing, but its a whole world of difference."

Oh yes, I admit my mistake. And you?