search

pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.63k stars 377 forks source link

Police ship should not be hardcoded #1237

Closed johnbartholomew closed 8 years ago

johnbartholomew commented 12 years ago

At the moment, the ladybird is hardcoded as the police ship (see SpaceStation.cpp:473). Probably the tag system should be used instead.

Related: #1221

robn commented 12 years ago

In the long term I'd probably look to have the whole lot farmed out to Lua. If a crime of the appropriate kind occurs, spawn some ships of a particular type. More infrastructure required there, of course. Adding a police tag would be a good first step.

Luomu commented 12 years ago

Well... tags are for models and ships are separated from models now (instead there are define_ship, define_static_ship and define_missile functions). I guess there should be a "shipset" config file for each faction, which would also determine the police ships and make them un-purchasable.

fluffyfreak commented 12 years ago

I was thinking of making this part of the factions work I'm looking into (reminds me, must add as an issue!) whereby each faction would define what ship they used for Police duties and what skin/material/texture it used.

That way we'd just have ships, some kind of tag in the ship definition that said "this is a police texture", and then factions would pick which ships they use. Different faction == different police ships.

impaktor commented 10 years ago

I've actually fixed this in my lawAndOrder_to_lua-branch

Police ship is set in faction file, or else default is used, which is set in the Lua side.

bszlrd commented 10 years ago

It's time to make some police skins for other ships? :)

impaktor commented 10 years ago

@nozmajner varada is a pretty sweet police ship I think. Alas, my branch triggers a seg fault when loading, which has pretty much halted my work on it for now.

corundscale commented 10 years ago

Shouldn't there be a support for more than one police ship per faction? Something like varada or kanara might make excellent interceptors but won't have firepower to pacify a large ship kitted for combat.

laarmen commented 10 years ago

impaktor: have you tried rebasing it on the current master? your segfault might have come from a Lua stack overflow, which was fixed last week or so.

impaktor commented 10 years ago

@laarmen yes, rebased the branch one week ago on top of 51db8c3ba965dc0ad9646daa45770eebf8271386 (after the many chrash bugs were fixed) - no change.