fluffyfreak
commented
9 years ago What is extra scary about that is that the test should be (idx<4) not (idx<=4) so something must have gone very wrong!!!
Closed haxys closed 8 years ago
fluffyfreak
commented
9 years ago What is extra scary about that is that the test should be (idx<4) not (idx<=4) so something must have gone very wrong!!!
fluffyfreak
commented
9 years ago @eloquentmess what star system were you in when this happened? How many stars were there?
fluffyfreak
commented
9 years ago From looking at RendererGL I suspect that the m_numLights is never being initialised.
The question then becomes why not? However I can create a fix for the crash itself.
fluffyfreak
commented
9 years ago @eloquentmess if you can give #3341 a test that would be great.
fluffyfreak
commented
9 years ago Ok this should definitely have been fixed by #3341 however this hasn't been closed and I haven't heard back from @eloquentmess since it's only been an hour :)
Lets keep this issue open until he's had a chance to reply.
haxys
commented
9 years ago I'll test it now.
haxys
commented
9 years ago Still crashing. Here's the info from the point I clicked "Start from Earth."
Creating new galaxy generator 'legacy' version 1
Clearing and re-using previous Galaxy object
StarSystemCache: misses: 0, slave hits: 0, master hits: 0
SectorCache: misses: 101, slave hits: 0, master hits: 1
Sol:
height fractal: Ellipsoid
colour fractal: StarG
seed: 1685209112
Mercury:
height fractal: HillsCraters2
colour fractal: Rock
seed: 6
Venus:
height fractal: RuggedLava
colour fractal: Desert
seed: 1710384323
Earth:
height fractal: Mapped
colour fractal: EarthLikeHeightmapped
seed: 1717547535
Moon:
height fractal: Mapped2
colour fractal: Rock2
seed: 4294967291
Mars:
height fractal: MountainsRidged
colour fractal: TFPoor
seed: 4294967293
Phobos:
height fractal: Asteroid4
colour fractal: Asteroid
seed: 439771126
Deimos:
height fractal: Asteroid4
colour fractal: Asteroid
seed: 806180402
Warning: Lua custom Systems definition: Surface starport has been automatically relocated. This is in order to place it on flatter ground to reduce the chance of landing pads being buried. This is not an error as such and you may attempt to move the starport to another location by changing latitude and longitude fields.
Surface starport name: Tomm's Sanctuary, Body name: Deimos, In sector: x = 0, y = 0, z = 0.
Io:
height fractal: RuggedLava
colour fractal: Volcanic
seed: 4294967292
Warning: Lua custom Systems definition: Surface starport has been automatically relocated. This is in order to place it on flatter ground to reduce the chance of landing pads being buried. This is not an error as such and you may attempt to move the starport to another location by changing latitude and longitude fields.
Surface starport name: Dante's Base, Body name: Io, In sector: x = 0, y = 0, z = 0.
Europa:
height fractal: Barren Rock 2
colour fractal: Ice
seed: 2102431459
Ganymede:
height fractal: HillsNormal
colour fractal: Rock
seed: 3062955636
Warning: Lua custom Systems definition: Surface starport has been automatically relocated. This is in order to place it on flatter ground to reduce the chance of landing pads being buried. This is not an error as such and you may attempt to move the starport to another location by changing latitude and longitude fields.
Surface starport name: Enki Catena, Body name: Ganymede, In sector: x = 0, y = 0, z = 0.
Callisto:
height fractal: MountainsCraters2
colour fractal: Rock
seed: 1272712740
Dione:
height fractal: Barren Rock 3
colour fractal: Rock
seed: 3732948941
Rhea:
height fractal: RuggedDesert
colour fractal: Rock
seed: 1174493206
Titan:
height fractal: MountainsVolcano
colour fractal: Desert
seed: 0
Iapetus:
height fractal: Barren Rock 3
colour fractal: Rock
seed: 3650944653
Ariel:
height fractal: MountainsCraters2
colour fractal: Rock
seed: 3952866153
Umbriel:
height fractal: Barren Rock 3
colour fractal: Rock
seed: 699943475
Titania:
height fractal: Barren Rock 3
colour fractal: Rock
seed: 2461415048
Oberon:
height fractal: MountainsCraters2
colour fractal: Rock
seed: 663490636
Proteus:
height fractal: Asteroid4
colour fractal: BandedRock
seed: 1251043226
Triton:
height fractal: Barren Rock 3
colour fractal: Rock
seed: 1155973133
Nereid:
height fractal: Asteroid4
colour fractal: BandedRock
seed: 3055461756
Pluto:
height fractal: HillsCraters2
colour fractal: Rock
seed: 3037711761
Charon:
height fractal: HillsCraters2
colour fractal: Rock
seed: 2191294907
CreateCollisionMesh for : (kanara)
Assertion failed: (idx<=4), function GetLight, file ./../graphics/Renderer.h, line 87.
Abort trap: 6Still not working.
fluffyfreak
commented
9 years ago Damn, I'll have to try debugging it on my MacMini. Not done any actual debugging on it before!
Weirdly there should be no place where it tries to pass a value outside the range 0..3 anywhere in the code :(
laarmen
commented
9 years ago Last time I had a similar bug, it was because of a silent conversion to unsigned int in a substraction, in case that helps.
fluffyfreak
commented
9 years ago Ok well I just fetched the latest master and built on OSX but everything worked fine. At 12fps but otherwise fine.
jameynakama
commented
9 years ago Seconding this error. Exact same output on Yosemite 10.10.2 when starting from Earth or New Hope, but not Barnard's Star.
jameynakama
commented
9 years ago I'm using the binary build. I tried to build from source but ran into early errors with Xcode not being able to find SDL.h. I'm using brew and installed all the packages I could find equivalents for, but some in the list for MacPorts weren't available.
build: git 50c25a6
Release(Kernel) Version: 14.1.0
Kernel Build Timestamp: Darwin Kernel Version 14.1.0: Mon Dec 22 23:10:38 PST 2014; root:xnu-2782.10.72~2/RELEASE_X86_64
Machine Arch: x86_64
SDL Version 2.0.3
Initialized OpenGL 3.1, with extensions, renderer
impaktor
commented
9 years ago as far as I can tell, no new merges have been made to the code since @eloquentmess reported that it still crashes, 3 days ago.
jameynakama
commented
9 years ago Further info: building from source on Yosemite the autotools way works! The Xcode build must be busted.
fluffyfreak
commented
9 years ago @jameydeorio ah ha! That's very helpful, thanks. I was building the autotools way as I always do. I have never tried to build it using XCode.
jameynakama
commented
9 years ago I've been attempting builds but can't get Xcode to stop complaining about SDL and some other libraries being missing.
impaktor
commented
9 years ago ...and some other libraries being missing.
libcurl-dev is also required. It's been added to the dependency list now.
haxys
commented
9 years ago I've been building with the command-line tools. I built a script to automatically pull, compile, fix dependencies and assemble the app bundle. It's been working for a good while now, without any changes.
Have the dependencies changed for the code?
fluffyfreak
commented
9 years ago @eloquentmess do you have that script handy? I have no idea how to build the app bundle from the command-line build.
haxys
commented
9 years ago I'm sorry guys, I've been so busy with school that I've been away from this project entirely. The script uses a few custom tools, but it shouldn't be hard to figure out how to get it running on another Mac. I'm not at that computer at the moment, but I'll try to get the code posted soon. It's not clean, it's not pretty, and it's not entirely rational, but it works well enough.
fluffyfreak
commented
9 years ago Apparently this is still happening even for the latest builds (#3379).
I think we need to figure out how to bundle a build into an app so we can supply new OSX builds asap.
fluffyfreak
commented
9 years ago A quick Googling presents us with: A StackOverflow answer which looks very good. The mozilla OSX bundle pages. And some random pascal(?) page.
EDIT: and a handy tool to automate some of the dependency parts of this.
SilkyPants
commented
9 years ago I think I've got a working build with Xcode now in my fork for the Mac build, and have confirmed it running on a couple of Mac minis at work. Just need to figure out the process for pull requests and build chain.
Currently links against a few libraries in the third party repository, and builds into a self contained app.
impaktor
commented
9 years ago @eloquentmess you can build on mac, so if you have time, perhaps you could share your wisdom and/or just push a working branch/script to your github?
fluffyfreak
commented
9 years ago @SilkyPantsDan that's great news :)
TheQwak
commented
9 years ago Hi, I can confirm this error too.
On the current Mac build it crashes on start-up at a planet, or when approaching within ~2.8 AU of any planet. Dump below.
In the meantime, apart from Barnard's, does anyone know what, if any, systems have space stations without planets?
An assertion failed in the GetLight function in graphics/Renderer.h, line 87.
Here's the generated error:
Here's the dump: