pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.64k stars 380 forks source link

wheels up audio should continue upon hyperspace countdown initiation #3804

Closed Digit closed 6 years ago

Digit commented 8 years ago

Observed behaviour

"wheels up" audio cuts out upon initiation of hyperspace countdown,

instead of

Expected behaviour

"wheels up" audio continues during countdown, only cutting out upon initiation of hyperspace jump

after taking off, hit f6 (or clicking wheels up button), and while the sound is playing, with a destination selected to jump to, hit f7 (or clicking the hyperspace button), wheels up audio cutting out upon initiating hyperspace countdown is jarring and ruins suspension of disbelief.

My pioneer version (and OS): running pioneer-20160814-linux64:

richardpl commented 6 years ago

This does not happen any more, if one try to start hyperjump with wheels not completely retracted alarm will be played. And there is already another PR to fix audio crossfade issues.

richardpl commented 6 years ago

Should be fixed.