search

pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.64k stars 379 forks source link

Inifinte galaxy, now with rectangular patches of systems too! #5160

Open bszlrd opened 3 years ago

bszlrd commented 3 years ago

Observed behaviour

The galaxy is being generated indefinitely on the X and Y direction. I can't verify the Y though, because the movement in the map is relative to the view plane, so even the default view leads to the other odd behaviour: random rectangular, sometimes layered patches of stars. On this screenshot the selected star is 6 million lightyears away from Sol, even though the Milky Way is about 185 000 ly across: screenshot-20210404-092417 I've even found inhabited systems in this far region, with settlements and millions of inhabitants.

If you only move up or down, everything seems to be fine, nothing repeats in that direction. But if you decide to move in a random direction that has up or down as well, you then run into oddly layered rectangular patches of systems here and there: 5Irh6m8 screenshot-20210404-093011 These huge patches of stars seem to be rectangular, but their height is much larger, but not infinite. Sometimes they have independent systems even. From the side they are quite layered

Expected behaviour

Galaxy ending where it should end.

Steps to reproduce

Go to the system map, zoom out as far as you can, then move left or right with shift+A or shift+D. The galaxy will thin out as it should, then you find another. Then another. Then another... Video

If you rotate the view randomly, and do the same, you will eventually run out of galaxy, but rectangular patches will appear here and there. I think you need to go at least a bit up or down for these to appear. Video

Can't give coordinates, because the generated names are too long, and they aren't properly visible.

My pioneer version (and OS): Win10, 20210328 Master - 8052a59 build via the github artifact. It happened with the #5157 build as well.

bszlrd commented 3 years ago

And if I invert the galaxy bmp, the inifiniteness is even more noticeable, since the galaxy won't ever disapear since there aren't any black parts. And the galaxy is also infinite in the 2020 february release, but I can't find any of the rectangular parts, but that might be because fast movement in the map with shift is quite a bit slower in that build.