pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.64k stars 379 forks source link

Combat missions fail if you arrive late for payment. #5180

Open tropicalpioneer opened 3 years ago

tropicalpioneer commented 3 years ago

Observed behaviour

Not a bug, but does it really make sense that after winning the fight, you fail the mission for being late at the payment? I understand if it is in open space and the paying ship is waiting, but what about the Combat mission accomplished for the police, where the payment happens in basically any station?

Expected behaviour

A more flexible timing for receiving the payment, at least for Police Combat missions paid at the stations.

Steps to reproduce

My pioneer version (and OS): 20210205 Mint Cinnamon 20.1

impaktor commented 3 years ago

@robothauler thoughts?

robothauler commented 3 years ago

In my opinion, the current behavior makes sense. If the Police plan a chain of operations, they may want to analyze the data before going to the next step. Especially when they hire a mercenary. If they get the data too late, the entire plan might get messed up.

tropicalpioneer commented 3 years ago

This means that the "primary mission objective ok" message in CommLog during battle is not sent by the hiring institution, otherwise they'd know the job is done.

Does that mean that I physically need to be proving the killings? For example the hiring institution needs to read the data from a kind of black box or other incorruptible device on my ship.

Otherwise, if I do not need to be physically there, how about a 3220AD interstellar "phone call" :) to keep the chain of operations updated, then wire the money whenever I am in range?

A joke to close this post... yeah, I understand that Police can be rigid with their procedures and make you travel MMMmiles for a word, just to prove they got the power.

tropicalpioneer commented 3 years ago

oh, and when the payment appointment is in open space, who am I talking with and passing the data to? Is there a ship waiting somewhere after hyperjump, to get in range with, chit chat the adventure around a floating spherical beer (or a black box full of data) and getting paid?

robothauler commented 3 years ago

This means that the "primary mission objective ok" message in CommLog during battle is not sent by the hiring institution, otherwise they'd know the job is done.

It's a message from the ship's mission computer to the pilot. And yes, the CommsLog should indicate better who is saying what.

Does that mean that I physically need to be proving the killings? For example the hiring institution needs to read the data from a kind of black box or other incorruptible device on my ship.

In my opinion, yes.

Otherwise, if I do not need to be physically there, how about a 3220AD interstellar "phone call" :) to keep the chain of operations updated, then wire the money whenever I am in range?

The speed of light is too slow. The hyperdrive is faster! :-)

robothauler commented 3 years ago

oh, and when the payment appointment is in open space, who am I talking with and passing the data to? Is there a ship waiting somewhere after hyperjump, to get in range with, chit chat the adventure around a floating spherical beer (or a black box full of data) and getting paid?

Yes, there is a ship! I noticed that sometimes the time acceleration didn't stop after entering the target system. So the ship jumps out and you see only the hyperdrive departure cloud in your vicinity.

tropicalpioneer commented 3 years ago

I am new to hyper-drive thinking and I get the speed relation now. Funtastic! :)

Maybe there is a way to make the post hyper-jump meeting more tangible? Would it be too much programming/navigation if we have to get closer to that waiting ship? (thinking about those 50m needed in physical transfers: staff, fuel, ...)

Will you pull a request to make explicit the message senders in CommsLog?

tropicalpioneer commented 3 years ago

I added a feature request about the CommsLog, it deals with making it easier to read the latest entries, and it might be quite easy to implement.