search

pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.62k stars 375 forks source link

Ship Capacity on Station Market screen doesn't match Cargo Capacity in Ship Info #5478

Open Bodasey opened 1 year ago

Bodasey commented 1 year ago

Observed behaviour

Bulletin Board and Commodity Market display the allover free capacity as in the equipment market. (differs a lot with a low equipped coronatrix ship)

Expected behaviour

Bulletin Board and Commodity Market should display the free cargo space as in personal info -> Commodity and trade In the equipment market, another symbol should be used aside the percent character.

My pioneer version (and OS): actual master

Bodasey commented 1 year ago

Fuel scooping should also have a look to free cargo space first, and not the allover capacity and then realize there's no free space for the hydrogen to fit into. HowManyTonsH2

ghost commented 1 year ago

I have the same problem with cargo space on the coronatrix. Some places it shows one thing, other places it shows another as far as available capacity. In the ship data, /pioneer/data/ships/coronatrix.json it shows "capacity": 30, and then in the "slots" section shows cargo as 16 (and missiles 10?). I'm not sure which is correct. Is it supposed to have a cargo capacity of 16 and 10 missile slots, or is it supposed to have capacity of 30...? The pumpkinseed.json seems to be in a similar state, capacity 17, cargo 10. While the xylophis.json seems like it adds up, it says capacity 10, cargo 10, and I haven't had issues loading it all the way up yet. I haven't checked any of the other ship files yet (I haven't used any of the other ships yet), so I don't know if there are others with similar issues. I think the easy solution is to edit the .json file, which works, you seem to be able to change any of those values to anything you want. I'm not sure which cargo/missile capacity is meant to be correct, though.
On void linux, master, 20230201.

bszlrd commented 1 year ago

The difference between cargo capacity and overall capacity is a somewhat clumsy way to differentiate between ships a bit more. Capacity includes equipment space and cargo capacity. Two parts of a Venn diagram overlapping to a certain level. In a sense it is an attempt to make ships not being about a single stat, not to be a shell where you can just shove in everything without structure. The aim is to transition towards a more slot/hardpoint based approach where cargo capacity is mostly divorced from equipment.

Web-eWorks commented 8 months ago

Assigning @nozmajner since you're working on mockups to more clearly show cargo vs. equipment space in StationView contexts where that information is required.

bszlrd commented 8 months ago

Roger roger. I'll think about a scooping HUD while I'm at it.

Digit commented 2 weeks ago

(8691843e1)

Changed ship, to an AC-33, and seems afflicted with this bug too.

[No effect on station's capacity readout from refuelling. Capacity says 293t free, but isn't and cant buy more. Station's Lobby window's main fuel bars, and Ship's Economy and Cargo windows all show it correctly.]

Does it only happen on some ships? Consistently? Or something unrelated to ship model, triggering this?

bszlrd commented 2 weeks ago

It happens to all ships. There's an overall capacity for cargo and equipment, and the cargo capacity is a subset of that. We want to move to a hardpoint based equipment system, which would solve this mostly.