pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.64k stars 380 forks source link

Eclipse issues with atmoshpere and star eclipsing star #5489

Open DynV opened 1 year ago

DynV commented 1 year ago

Observed behaviour

At certain stations of Huber's World, in the Anvudrad system, there's no star in the background; the system star can be seen but beyond that it's pitch black. At ~10 Km altitude I could--barely--see the background and at ~13 like 1/4 its brightness, or slightly more.

I did an issue search for "no stars" with many results and I didn't do through all of them, so sorry if this is a duplicate.

Expected behaviour

See stars in the background.

Steps to reproduce

  1. Load the gamesave
  2. look around.

My pioneer version (and OS): 20220203-win

The attached file was simply renamed so it would go through the upload extension filter, there was no modification to the file content of my save-file. screenshot-20230124-021957 screenshot-20230124-025721 Pioneer-Yoan_Faure-260609-no_star_in_background.zip

bszlrd commented 1 year ago

I can confirm this, and I think it is a misbehaving eclipse. screenshot-20230124-094350

At around 18:19 it starts to go away: screenshot-20230124-094215 screenshot-20230124-094230 screenshot-20230124-094328

The problem is, a star eclipsing another star should not cause this kid of darkness, and in general it should not hide the stars and sky either. I've edited the issue title. Quite a coincidence, I don't think anybody ever bumped into a star eclipsing star situation yet. See also #4961

If you zoom out in external view or fly away, the sky gradually fades back, skybox included: screenshot-20230124-092357 And from certain directions it looks like this: screenshot-20230124-092408

I've dug out an old screenshot of mine from Sol, from quite a few years from now. In that case the sky does not disappear, so something might have changed since that: image

But in that location, the sky does not disapear on master(ish, a week old build), nor on last year's build: screenshot-20230124-095510

Also, our Saturn is still beautiful :) screenshot-20230124-095751

impaktor commented 1 year ago

Interesting find, thanks for reporting

DynV commented 1 year ago

I case you needed a 2nd one, see attached; on same version. screenshot-20230128-041551 screenshot-20230128-041558 screenshot-20230128-041613 Pioneer-Yoan_Faure-260824-another_erroneous_eclipse.zip