pioneerspacesim / pioneer

A game of lonely space adventure
https://pioneerspacesim.net
1.63k stars 377 forks source link

Can undock from station with less than "minimum crew" #5688

Open hexagonrecursion opened 10 months ago

hexagonrecursion commented 10 months ago

Observed behaviour

Some ships have "minimum crew". You are not supposed to be able to leave port if you do not have sufficient crew, but the "Undock" HUD button image appears to bypass that.

Autopilot also bypasses that.

Expected behaviour

You should not be able to undock if you do not have enough crew.

Steps to reproduce

  1. Be docked at the station
  2. Set your ship to "Skipjack" (min crew 2)
  3. Fire your crew if you have any
  4. Switch to internal, external or siderial view
  5. Click the undock button at the bottom of the screen next to the speed limiter button

Alternative step 5 - give the autopilot any command - the autopilot will undock you even if you don't have enough crew

My pioneer version (and OS): 97d7be673f2124f1b42aee956c4b3a6fc2129558 (and Fedora release 39)

My output.txt (required) and game save (optional, but recommended) output.txt No save necessary - 100% reproducible in a fresh game

Notes

The "Request Launch" button in the "lobby" does correctly prevent the launch if there is not enough crew

Web-eWorks commented 10 months ago

This is technically "by design" at the moment, as the crew mechanics are very incomplete and the game does not currently provide adequate opportunities for a player to hire enough crew to prevent them from being trapped at a station after e.g. buying a new ship.

We intend to improve on the crew mechanics in the future, but there is a lot of underlying work to be done before crew have an effective reason for existing.