Release 20240314 fails to load saves from previous release.

SylvainBoilard commented 2 months ago

Observed behaviour

Loading a game saved in version 20240203 into 20240314 fails with the message "Error: This saved game cannot be loaded because it contains errors".

Expected behaviour

Loading a game saved in the previous version succeeds.

Steps to reproduce

Save a game in version 20240203
Upgrade to version 20240314
Try to load the same game

My pioneer version (and OS): 20240314 on Debian GNU/Linux Testing

My output.txt (required) and game save (optional, but recommended) output.txt Sylvain_001.gz

pghvlaans commented 2 months ago

I ran into the same issue on Slackware64 -current. It appears that s_saveVersion wasn't bumped in src/Game.cpp, but when I changed the value to 91 myself and rebuilt, it worked as expected.

Gliese852 commented 2 months ago

Apparently there was an unplanned savegamebump.

@pghvlaans By changing the version, you triggered a recovery instead of a normal save load, in fact, you can simply press Ctrl in the save loading menu to force a recovery.

pghvlaans commented 2 months ago

in fact, you can simply press Ctrl in the save loading menu to force a recovery.

I didn't realize that. Thanks!

pioneerspacesim / pioneer