search

pionl / laravel-chunk-upload

The basic implementation for chunk upload with multiple providers support like jQuery-file-upload, pupload, DropZone and resumable.js
MIT License
602 stars 167 forks source link

L9 support #129

Closed drjdr closed 2 years ago

drjdr commented 2 years ago

Hi,

this is just a PR as POC for the adjustments for L9. My setup uses only PHP 8.1 and L9, so I didnt remove the old releases. Given the recent changes in Flysystem v3 I would do the following:

pionl commented 2 years ago

Hi @drjdr , this is perfect, I was expecting I had to do this (already did this on diff project).

I'm going to test it on older PHP versions and we will see, 30% ppl are stil using 7.4. https://packagist.org/packages/pion/laravel-chunk-upload/php-stats

pionl commented 2 years ago

As for this moment I wont drop older releases due the "older" state of the package and old usages.

Of course I would encourage everybody to upgrade to latest Laravel. I've dropped only Laravel 5/6. Other I am able to test via example repository + docker.

With little effort we can still support old versions. I've changed your code.

Unfortunately I'm not using the package anymore so my priorities are not here any more :( Maybe in future I will need it again and I will upgrade it with PHP 8.1 code base and major refactoring of some bad design choices.

Imho, I've updated the tests in chunk example and every test is Ok now. Took some time but managed it to fix all issues with it.

Thanks for the PR.

Tested on PHP 8.1 / 8.0 / 7.4 (Laravel below 9) - see example repository for more details.