pionl / smart-emailing-v3

Wrapper for SmartEmailing API v3 version in PHP
MIT License
13 stars 14 forks source link

Undefined method importRequest() #36

Closed tomasr1981 closed 6 months ago

tomasr1981 commented 6 months ago

Hi, something is missing? While using code from documentation:

use SmartEmailing\v3\Api;
$api = new Api('username', 'api-key');
$api->importRequest()->addContact(new Contact('test@test.cz'))->send();

I get an error about a missing method:

Uncaught Error: Call to undefined method SmartEmailing\v3\Api::importRequest()

MartinMystikJonas commented 6 months ago

It is weird. That method is there. What version do you have installed? It was nor present in older versions so maybe you somehow ended up with old version installed.

tomasr1981 commented 6 months ago

Hi, I installed last version 0.4. But documentation is from new version (1) which still is not on GIT.

On Wed, Apr 10, 2024, 09:14 Martin Mystik Jonáš @.***> wrote:

It is weird. That method is there. What version do you have installed? It was nor present in older versions so maybe you somehow ended up with old version installed.

— Reply to this email directly, view it on GitHub https://github.com/pionl/smart-emailing-v3/issues/36#issuecomment-2046689474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZTNPIGD4VM2UFS5TDYCPTY4TREBAVCNFSM6AAAAABF6BNNMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGY4DSNBXGQ . You are receiving this because you authored the thread.Message ID: @.***>

MartinMystikJonas commented 6 months ago

Version 1.0 is still in pre-release but you can install it. Or use dev-master.

@pionl Maybe you can publish v1.0 as full release already?

tomasr1981 commented 6 months ago

I'm just pointing out the inconsistency.

Documentation is related to 1.0 (importRequest() does not exists in 0.4) Snímek obrazovky pořízený 2024-04-10 14-19-45

Latest realease is 0.4

Snímek obrazovky pořízený 2024-04-10 14-19-23

MartinMystikJonas commented 6 months ago

README always point to latest dev version.

Latest release is v1.0.0-rc-2 but it is pre-release and GitHub shows latest stable release as latest.

tomasr1981 commented 6 months ago

Ok, this is confusing. Composer installs 0.4, the readme shows 0.4, but the documentation in the readme describes version 1.

On Wed, Apr 10, 2024, 17:05 Martin Mystik Jonáš @.***> wrote:

README always point to latest dev version.

Latest release is v1.0.0-rc-2 https://github.com/pionl/smart-emailing-v3/releases/tag/v1.0.0-rc-2 but it is pre-release and GitHub shows latest stable release as latest.

— Reply to this email directly, view it on GitHub https://github.com/pionl/smart-emailing-v3/issues/36#issuecomment-2047806337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZTNPPE4FNI2QTEH36PG4DY4VIMDAVCNFSM6AAAAABF6BNNMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXHAYDMMZTG4 . You are receiving this because you authored the thread.Message ID: @.***>

pionl commented 6 months ago

sorry guys, I was waiting for the final confirmation.

Next time for RC I'll try to change the default branch to last stable release.

pionl commented 6 months ago

@tomasr1981 new version release, you can change the version to v1.0.0 - https://github.com/pionl/smart-emailing-v3/releases/tag/v1.0.0