search

pionxzh / Get-Twitter-Icons-Back

Restore the icon of Twitter. No more 𝕏.
MIT License
64 stars 4 forks source link

Mobile support? #9

Closed Chudesnov closed 1 year ago

Chudesnov commented 1 year ago

Thanks for working on this project! I noticed that while it works with the desktop Twitter version, installing it using the Userscripts app on iOS doesn't change any icons in the mobile web UI (only the color of the X icon). Are you willing to accept a patch that would enable cross-platform support, or would it be out of scope?

pionxzh commented 1 year ago

Sure, PR's welcome. 👍

pionxzh commented 1 year ago

I just double-checked, seems it works on mobile without a problem. All icons are replaced successfully. Not sure what the actual issue. 🤔

Chudesnov commented 1 year ago

With Userscripts extension for iOS Safari it only partially works. Page title is replaced but icons are not IMG_1989 IMG_1988

Chudesnov commented 1 year ago

Looks like it might be more of an issue with Userscripts API rather than mobile vs desktop. I’ll take a look later when I have access to a Mac to inspect the script running on my phone

pionxzh commented 1 year ago

Oh, might be related to the css injection I guess.

Updated: checked the code and seems nothing is too latest, not sure what's wrong.

pionxzh commented 1 year ago

@Chudesnov Any update?

pionxzh commented 1 year ago

closing first. Let me know if you have new findings!