Does not work with JSON

piotr-cz / cockpit-import

Spreadsheet import module for Cockpit CMS

MIT License

23 stars 4 forks source link

Closed gryphonmyers closed 8 years ago

gryphonmyers commented 8 years ago

If I select a valid JSON file to import, it fails to correctly identify "columns."

Is it expecting a particular structure?

piotr-cz commented 8 years ago

Looks like the JSON import is broken in v1.1.0. You may try downgrading to v1.0.0-rc.1 if you are in a hurry

piotr-cz commented 8 years ago

Okay, this line should be

parseFn = parser.json;

It breaks location field, because it's passing object and filter expects string to geolocate

gryphonmyers commented 8 years ago

Ok I can mess around with it and do a PR when I get it working thanks

piotr-cz commented 8 years ago

I got it, but will commit tomorrow.

piotr-cz commented 8 years ago

Should be fixed in 87b69befe303151aa617f045dcdbeb9066366f14, please confirm.

Besides fixing relation to json parser I reset filters to noop type, as files exported from Cockpit should be already properly parsed.

gryphonmyers commented 8 years ago

Yes that appears to have resolved it