piotrC4 / mqtt-ir-transceiver

ESP8266 based bidirectional bridge between MQTT and IR (change MQTT message to IR signal and change received IR signal to MQTT message)
142 stars 34 forks source link

JVC Code #10

Closed aususer closed 6 years ago

aususer commented 6 years ago

Hi everyone.. dislaimer: I'm no actual programmer - just a tinkerer with an electronic background.

Just a heads up... was trying to add a new remote to the MQTT setup - and found that it would READ JVC IR codes but I could not publish them...

Doing some digging the in mqqt.cpp file, and compared it with the library, and I noticed that there was not a JVC entry to catch if mqtt is sending a JVC code request, so I simply copied the "LG" one, and manipulated it for JVC like so: ++line 390 else if (irTypStr=="JVC") {'sendToDebug(String("*IR: Send JVC:")+msgInt+" (bits: "+irBitsInt+")\n");' irsend.sendJVC(msgInt, irBitsInt); }

if your trying to get a JVC to work and it wont - this is what you need to do... and it works.

as a side point: It appears that JVC remotes are not the only remotes that are listed in the library but not implemented in mqtt.cpp... so there are likely other additions to me made in the future... that said - right now I am only looking a the JVC.

(EDIT: I originally had some problems - that I posted for help - but I have since fixed that - turns out that it doesnt just help to know that LED's have polarity... it really does help not to ASSUME that you are swapping red LED for IR leds and you have them in the right polarity.)

anyway - hope this helps someone else.

Mike Melbourne, Australia