it does not work on MAC os

piotrek-orlowski / FamaFrenchData

R package for download and tidying of the Kenneth French data library

GNU General Public License v3.0

5 stars 3 forks source link

it does not work on MAC os #1

Open MatixR opened 5 years ago

MatixR commented 5 years ago

Hi, Piotrek-orlowski,

This is a wonderful package for investigating the Fama-French Dataset.

But It does not work well on Mac system.

（1） In the "ff_tidy_data" function, the assignment should be changed into save_paths <- file.path(r_temp_dir, file_names) download_urls <- file.path(ff_ftp_url, file_names). because the "file.path()" works better for any operating system.

(2) the internal function “ff_data_extract” can not be found. I am not sure why it happens right now.

piotrek-orlowski commented 5 years ago

Hi MatixR

I made the suggested changes.

I can't reproduce your problem with ff_data_extract, unfortunately.