Fix crash on require 'github_api'

gekola commented 7 years ago

Without this patch I get the following error on require 'github_api'

rescue in block (2 levels) in require': There was an error while trying to load the gem 'github_api'. (Bundler::GemRequireError)
Gem Load Error is: uninitialized constant Github::VERSION
Backtrace for gem load error is:
.../github_api-0.18.0/lib/github_api/configuration.rb:47:in `<class:Configuration>'
more backtrace

coveralls commented 7 years ago

Coverage remained the same at 95.417% when pulling 0bda284265d8f3bf4ea3d03ef01d1bd9cec58b93 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

coveralls commented 7 years ago

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560526007d67e91edb4bf1e90eb96f9e2040 on gekola:fix-unitialized-const-version into a5bfbd72ac064ae9f9d137add026b3b9a1acce51 on piotrmurach:master.

piotrmurach commented 7 years ago

Thanks! ❤️

piotrmurach commented 7 years ago

Sorry for releasing such borked version of the library, I've yanked the v0.18.0 and released v0.18.1 with your patch!

piotrmurach / github

Fix crash on require 'github_api' #325