search

piotrmurach / strings

A set of useful functions for transforming strings.
MIT License
129 stars 12 forks source link

ruby 2.7 warnings #9

Closed zenspider closed 5 years ago

zenspider commented 5 years ago

Tons of warnings coming up when I test our gem against ruby 2.7:

.../strings-0.1.7/lib/strings.rb:19: warning: The last argument is used as the keyword parameter
.../strings-0.1.7/lib/strings/align.rb:39: warning: for `align' defined here
.../strings-0.1.7/lib/strings/align.rb:42: warning: The last argument is used as the keyword parameter
.../strings-0.1.7/lib/strings/align.rb:85: warning: for `align_center' defined here
.../strings-0.1.7/lib/strings.rb:19: warning: The last argument is used as the keyword parameter
.../strings-0.1.7/lib/strings/align.rb:39: warning: for `align' defined here
.../strings-0.1.7/lib/strings/align.rb:42: warning: The last argument is used as the keyword parameter
.../strings-0.1.7/lib/strings/align.rb:85: warning: for `align_center' defined here

probably more, with the output above limited by our usage of the gem.

zenspider commented 5 years ago

I figured out that I named the travis setup wrong... it should be 2.7.0-preview2.

piotrmurach commented 5 years ago

Released new version 0.1.8 with your fix.