Fix environment variable persistence

piotrmurach / tty-command

Execute shell commands with pretty output logging and capture stdout, stderr and exit status.

https://ttytoolkit.org

MIT License

400 stars 34 forks source link

Fix environment variable persistence #61

Closed DannyBen closed 3 years ago

DannyBen commented 3 years ago

Closes #60

I added test in the most appropriate place I could think of and verified the test fails without the fix. All other specs pass locally.

coveralls commented 3 years ago

Coverage remained the same at 94.843% when pulling b522f8c1cb02442eaa7980ed18b1cf54102f41c8 on DannyBen:fix-env-vars-persistence into 1f0777df14c82444bec0d973b595091002023111 on piotrmurach:master.

DannyBen commented 3 years ago

Would you have time to...

Yes. Stand by :)

DannyBen commented 3 years ago

Pulled and merged upstream master
Added changelog entry
Resolved all but one Hound complaints
Simplified the spec to compare only to the part of the string we care about

And by the way - you have editing privileges on my branch, so feel free to touchup whatever you want.