search

piotrmurach / tty-command

Execute shell commands with pretty output logging and capture stdout, stderr and exit status.
https://ttytoolkit.org
MIT License
400 stars 34 forks source link

Remove successful execution logging #8

Closed piotrmurach closed 8 years ago

piotrmurach commented 8 years ago

I think you could probably ditch the with exit status 0 (successful) and only log failures. That will make them stand out more, I think. Or at least make successful use the same color as the rest of the line.

gurgeous commented 8 years ago

Want a PR for this?

piotrmurach commented 8 years ago

I prefer to be notified of execution status regardless, don't really see the failure as special case. Also I'm a stickler for consistency :) Therefore, I would probably leave it as is. However, having said that I think we may provide different printers, one with no-frills implementation?

gurgeous commented 8 years ago

That sounds fine. I can picture a very quiet printer... :)

piotrmurach commented 8 years ago

I will abstract away the common behaviour for printer and then we can provide few versions including very quiet one :)

piotrmurach commented 8 years ago

I've abstracted away printers and provided :printer option for specifying either printer name or class. Any other printers welcome!

gurgeous commented 8 years ago

At this point this is the same as issue #1, so let's close.