search

piotrmurach / tty-prompt

A beautiful and powerful interactive command line prompt
https://ttytoolkit.org
MIT License
1.47k stars 136 forks source link

Use set help_color in multi_select prompt #119

Closed robbystk closed 4 years ago

robbystk commented 4 years ago

Setting the help color in the prompt initialization or as an option to the multi_select method sets @help_color, so we can use that when printing the help message for multi_select prompts.

Describe the change

Makes multi-select prompt help messages print in the specified color.

Why are we doing this?

The default help color is invisible with the popular 'solarized' terminal scheme.

Benefits

The help color can be changed by users of the gem.

Drawbacks

This only changes one instance of this type of bug. There are no more for help color but there may be others for active color and error color.

Requirements

Put an X between brackets on each line if you have done the item: [x] Tests written & passing locally? [x] Code style checked? [N/A] Rebased with master branch? [N/A] Documentation updated?

For #118

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 96.935% when pulling 0af7d580b66cc944f017d9dd75eaf59f0202cab2 on robbystk:multi-select-help-color into 341d6cb4cbf91c536582e174ae47ba63dcd0bb0e on piotrmurach:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.1%) to 96.956% when pulling 0af7d580b66cc944f017d9dd75eaf59f0202cab2 on robbystk:multi-select-help-color into 341d6cb4cbf91c536582e174ae47ba63dcd0bb0e on piotrmurach:master.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.01%) to 97.066% when pulling a6ebe98e236ef2003b0ffdcd06e6349798c9f680 on robbystk:multi-select-help-color into 341d6cb4cbf91c536582e174ae47ba63dcd0bb0e on piotrmurach:master.

piotrmurach commented 4 years ago

Thanks ❤️